refactor wpdb statements #165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwmarkle
requested changes
Dec 21, 2022
| * @param array $values, | ||
| * @return array $placeholders | ||
| */ | ||
| public function get_prepare_placeholders( $values ) { |
There was a problem hiding this comment.
This method is get prepare placeholders.
The method itself is not doing any sql preparing, nor is it doing anything with placeholders. It's simply looping through an array and merging things.
Is it really needed? Maybe we rename it to something that makes more sense?
| ); | ||
|
|
||
| $query = $wpdb->prepare( | ||
| "SELECT `ID` FROM $wpdb->posts WHERE `post_content` LIKE %s AND `post_status` IN ( " . |
There was a problem hiding this comment.
I'm trying to peer review and figure out what has changed... The PR can be much cleaner and easier to understand by not reformatting, unless it needs to be.
bwmarkle
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #123