Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cRPA Screening and external RPA corrections #119

Merged
merged 33 commits into from
Aug 7, 2023
Merged

Conversation

cjcscott
Copy link
Contributor

@cjcscott cjcscott commented Jul 28, 2023

This adds support for cRPA screening of fragment interactions into Vayesta.
Various varieties of cRPA are possible. By default the conventional approach screening all interactions in the cluster via the screening equation is used; two phenomenological modifications are also supported (screening only the occupied-virtual interactions to avoid unintended reference modifications, and incorporating a term originating from the irreducible polarisability into the coupling of the cRPA to the cluster).

Thing left to do:

  • Print a warning if cRPA is used with any fragmentation other than CAS.
  • Add test for RPA external energy corrections.
  • Add screening example.

… for screened interactions, in orbitally invariant manner.
…default to not include irreducible polarisability.
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f72e4a5) 0.00% compared to head (0270c47) 0.00%.
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #119    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files         138     139     +1     
  Lines       18372   18645   +273     
=======================================
- Misses      18372   18645   +273     
Files Changed Coverage Δ
vayesta/core/qemb/fragment.py 0.00% <0.00%> (ø)
vayesta/core/qemb/qemb.py 0.00% <0.00%> (ø)
vayesta/core/qemb/uqemb.py 0.00% <0.00%> (ø)
vayesta/core/screening/screening_crpa.py 0.00% <0.00%> (ø)
vayesta/core/screening/screening_moment.py 0.00% <0.00%> (ø)
vayesta/dmet/dmet.py 0.00% <0.00%> (ø)
vayesta/dmet/fragment.py 0.00% <ø> (ø)
vayesta/edmet/edmet.py 0.00% <0.00%> (ø)
vayesta/ewf/ewf.py 0.00% <0.00%> (ø)
vayesta/ewf/fragment.py 0.00% <0.00%> (ø)
... and 4 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vayesta/core/qemb/qemb.py Show resolved Hide resolved
vayesta/edmet/edmet.py Outdated Show resolved Hide resolved
vayesta/tests/ewf/test_rpa_correction.py Outdated Show resolved Hide resolved
@cjcscott cjcscott requested a review from ghb24 August 4, 2023 14:58
@obackhouse
Copy link
Contributor

LGTM

@ghb24
Copy link
Contributor

ghb24 commented Aug 7, 2023

Can we add an mRPA example for solids? e.g. a minimal Graphene cell based on what was done in the paper, including the bare and screened correlation functions?

@cjcscott
Copy link
Contributor Author

cjcscott commented Aug 7, 2023

Use of mRPA with specifically graphene actually requires functionality in the next PR (use of non-PSD cderis with RIRPA). I have an example ready to go with that after this is merged.

@cjcscott cjcscott merged commit 583b949 into master Aug 7, 2023
7 checks passed
@cjcscott cjcscott deleted the crpa_screening branch August 7, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants