Bugfix PR: This fixes a bug introduced while re-enabling calculation of rdm1 in variational embedding #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of rdm1 in variational embedding
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #127 +/- ##
=======================================
Coverage 71.57% 71.57%
=======================================
Files 145 145
Lines 19357 19356 -1
Branches 3111 3111
=======================================
Hits 13854 13854
+ Misses 4738 4737 -1
Partials 765 765
☔ View full report in Codecov by Sentry. |
…nts for rscf case, added tests for composite wf tp ensure coverage for calc_ci_elements. the tests pass locally. GTM!
|
so basically the codecov patch shows an error as the tests are skipped. The actual tests have covered the said lines, I checked! |
cjcscott
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.