Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors SCMF UHF code #134

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

maxnus
Copy link
Contributor

@maxnus maxnus commented Sep 20, 2023

This is to reduce code duplication in the UHF versions of SCMF, which now calls the RHF update twice.

Together with #133 this addresses #132 for the UHF case

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 80.95% and project coverage change: -0.05% ⚠️

Comparison is base (56248bb) 71.58% compared to head (dbb970f) 71.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   71.58%   71.53%   -0.05%     
==========================================
  Files         152      152              
  Lines       20194    20152      -42     
  Branches     3336     3343       +7     
==========================================
- Hits        14455    14415      -40     
+ Misses       4909     4904       -5     
- Partials      830      833       +3     
Files Changed Coverage Δ
vayesta/core/scmf/brueckner.py 81.81% <75.00%> (ø)
vayesta/core/scmf/pdmet.py 73.13% <86.20%> (-8.45%) ⬇️
vayesta/core/scmf/scmf.py 91.56% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhishekkhedkar09
Copy link
Contributor

I tested, and both #133 and this one fixed the issue and passed the regression test. we can merge!

@maxnus maxnus merged commit ef8ecda into BoothGroup:master Sep 21, 2023
7 checks passed
@maxnus maxnus deleted the refactor_scmf_uhf branch September 21, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants