Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support imaginary frequency grids #6

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Support imaginary frequency grids #6

merged 4 commits into from
Aug 13, 2024

Conversation

basilib
Copy link
Contributor

@basilib basilib commented Jul 25, 2024

This PR adds the option to obtain a Lehmann representation on an imaginary frequency grid.
Also fixes a bug for left Hamiltonian application when calculating the moments.

@basilib basilib requested a review from obackhouse July 25, 2024 12:56
@obackhouse obackhouse changed the title Fix bug Suuport imaginary frequency grids Jul 26, 2024
@obackhouse obackhouse changed the title Suuport imaginary frequency grids Support imaginary frequency grids Jul 26, 2024
@obackhouse
Copy link
Collaborator

thanks, can you run the linters? from inside the repo directory do:

python -m black dyson/
python -m isort dyson/

Copy link
Collaborator

@obackhouse obackhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (2ac9352) to head (fb398e9).

Files Patch % Lines
dyson/lehmann.py 0.00% 6 Missing ⚠️
dyson/expressions/expression.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master      #6   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          27      27           
  Lines        2392    2396    +4     
======================================
- Misses       2392    2396    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@basilib basilib merged commit 3e6d6fe into master Aug 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants