-
Notifications
You must be signed in to change notification settings - Fork 205
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
9378584
commit cd86153
Showing
10 changed files
with
1 addition
and
24 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd86153
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Puffin runs fine for me on PiOS bookworm 64-bit.
The error you saw was on a user's Pi OS Bookworm 32-bit system. Is is possible that its dependence on that mmal library only affected the 32-bit version and not the arm64 version? If so then I think only the install-32 script should have been dropped.
cd86153
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh. yes I can confirm only the armhf version depends on the legacy gpu/camera libraries. the arm64 version does still work (as well on non-pi systems)
I think the "The Puffin browser demo was never maintained by the upstream developers." still applies as does the "other arm devices Puffin will not work" (for arm32 at least).
I still don't think anything was really lost here and want to keep it removed for multiple reasons which I will outline:
3a. very unsafe to use (many many vulnerabilities)
3b. bad or non-functional wayland support
3c. no vp9 decode support
I'm also not really comfortable keeping the (arm64) application given it has never been publicly acknowledged and it seems the developer have no interest in maintaining it.
Also something rubs me the wrong way when their own website doesn't handle adaptive sizing of webpages correctly (shrink the window and then expand it back at least on Firefox). Yes I know this reason may be silly.
cd86153
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Puffin has limited use still, despite its shortcomings, namely:
I'm doubting the outdated browser vulnerabilities could affect the user's end, but rather the browser side on the cloud server, in which case it's not risking the user.
I will add Puffin back for arm64, but warn about its limited usefulness and security concerns.
cd86153
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll note the only change to the runonce needed in that case is to change "" to "32". I think the name transitions happened long ago so no need to add those back imho.
cd86153
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The client still does the final pixel rendering and there have been multiple vulnerabilities with rendering and displaying content over the years (eg: https://fieldeffect.com/blog/latest-google-chrome-zero-day-likely-exploited-in-the-wild).