Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK-1217 workaround tvOS SPM issue #1381

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

echo-branch
Copy link
Contributor

Reference

SDK-1217 workaround tvOS SPM issue

Summary

Added preprocessor guards on all files that are not valid on tvOS. With other integration methods we can conditionally exclude these files, but it seems SPM does not allow this.

Motivation

Allow tvOS builds using SPM.

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)

Testing Instructions

Integrate Branch SDK into a tvOS app using SPM.
App should build properly.

cc @BranchMetrics/saas-sdk-devs for visibility.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.13%. Comparing base (4842da0) to head (8ff3e14).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1381      +/-   ##
==========================================
+ Coverage   51.03%   51.13%   +0.09%     
==========================================
  Files          66       66              
  Lines       10158    10158              
  Branches     3724     3724              
==========================================
+ Hits         5184     5194      +10     
+ Misses       4716     4705      -11     
- Partials      258      259       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nsingh-branch nsingh-branch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran a test with a tvOS app with and without this change, looks good to me.

@echo-branch echo-branch merged commit 88d7937 into master Apr 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants