Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2474] Fix for sending URI scheme as universal_link_url #1420

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

nsingh-branch
Copy link
Contributor

Reference

SDK-2474 -- Fix for sending URI schemes as universal_link_urls

Summary

When the app was opened via URI scheme, the SDK was incorrectly setting the universal_link_url as that URI. This is because the URI would be passed into the request factory and there wasn't a check for if it was actually a universal link instead of a URI. This would lead to requests incorrectly having external_intent_uri and universal_link_url be the same value.
This change adds a check for if urlString contains http or https to confirm its a universal link.

Motivation

To avoid having universal_link_url wrongly set to a URI.

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)

Testing Instructions

Open your app via a uri scheme (e.g. branchtest://) before and after the change and observe the external_intent_uri and universal_link_url fields in the requests to make sure they look correct.

cc @BranchMetrics/saas-sdk-devs for visibility.

@nsingh-branch nsingh-branch merged commit 60fca2a into master Aug 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants