Merge pull request #2417 from BrentOzarULTD/dev

2020-06-06 Quick Release
BrentOzarULTD · Jun 6, 2020 · c461609 · c461609
2 parents b156506 + 15b2890
commit c461609
Show file tree

Hide file tree

Showing 15 changed files with 82 additions and 62 deletions.
diff --git a/Install-All-Scripts.sql b/Install-All-Scripts.sql
@@ -30,7 +30,7 @@ SET NOCOUNT ON;
 BEGIN;
 
 
-SELECT @Version = '3.95', @VersionDate = '20200602';
+SELECT @Version = '3.95', @VersionDate = '20200606';
 
 IF(@VersionCheckMode = 1)
 BEGIN
@@ -1524,7 +1524,7 @@ SET NOCOUNT ON;
 
 BEGIN;
 
-SELECT @Version = '3.95', @VersionDate = '20200602';
+SELECT @Version = '3.95', @VersionDate = '20200606';
 
 IF(@VersionCheckMode = 1)
 BEGIN
@@ -2848,7 +2848,7 @@ AS
 	SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
 
-	SELECT @Version = '7.96', @VersionDate = '20200602';
+	SELECT @Version = '7.96', @VersionDate = '20200606';
 	SET @OutputType = UPPER(@OutputType);
 
     IF(@VersionCheckMode = 1)
@@ -12047,7 +12047,7 @@ AS
     SET NOCOUNT ON;
 	SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-	SELECT @Version = '3.96', @VersionDate = '20200602';
+	SELECT @Version = '3.96', @VersionDate = '20200606';
 
 	IF(@VersionCheckMode = 1)
 	BEGIN
@@ -13825,7 +13825,7 @@ BEGIN
 SET NOCOUNT ON;
 SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-SELECT @Version = '7.96', @VersionDate = '20200602';
+SELECT @Version = '7.96', @VersionDate = '20200606';
 
 
 IF(@VersionCheckMode = 1)
@@ -20614,7 +20614,7 @@ BEGIN
 SET NOCOUNT ON;
 SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-SELECT @Version = '7.96', @VersionDate = '20200602';
+SELECT @Version = '7.96', @VersionDate = '20200606';
 
 IF(@VersionCheckMode = 1)
 BEGIN
@@ -22681,19 +22681,19 @@ If one of them is a lead blocker, consider killing that query.'' AS HowToStopit,
 
 
     /* Query Problems - Statistics Updated Recently - CheckID 44 */
-	CREATE TABLE #UpdatedStats (Details NVARCHAR(4000), RowsForSorting BIGINT);
+	CREATE TABLE #UpdatedStats (HowToStopIt NVARCHAR(4000), RowsForSorting BIGINT);
     IF EXISTS(SELECT * FROM sys.all_objects WHERE name = 'dm_db_stats_properties')
     BEGIN
         EXEC sp_MSforeachdb N'USE [?];
-        INSERT INTO #UpdatedStats(Details, RowsForSorting)
-        SELECT Details = 
+        INSERT INTO #UpdatedStats(HowToStopIt, RowsForSorting)
+        SELECT HowToStopIt = 
                     QUOTENAME(DB_NAME()) + N''.'' +
                     QUOTENAME(SCHEMA_NAME(obj.schema_id)) + N''.'' +
                     QUOTENAME(obj.name) +
                     N'' statistic '' + QUOTENAME(stat.name) + 
                     N'' was updated on '' + CONVERT(NVARCHAR(50), sp.last_updated, 121) + N'','' + 
                     N'' had '' + CAST(sp.rows AS NVARCHAR(50)) + N'' rows, with '' +
-                    CAST(sp.rows_sampled AS NVARCHAR(50)) + N'' rows sampled, '' +  
+                    CAST(sp.rows_sampled AS NVARCHAR(50)) + N'' rows sampled,'' +  
                     N'' producing '' + CAST(sp.steps AS NVARCHAR(50)) + N'' steps in the histogram.'',
             sp.rows
         FROM sys.objects AS obj   
@@ -22705,13 +22705,18 @@ If one of them is a lead blocker, consider killing that query.'' AS HowToStopit,
     END;
 
 	IF EXISTS (SELECT * FROM #UpdatedStats)
-		INSERT INTO #BlitzFirstResults (CheckID, Priority, FindingsGroup, Finding, URL, Details)
+		INSERT INTO #BlitzFirstResults (CheckID, Priority, FindingsGroup, Finding, URL, Details, HowToStopIt)
 		SELECT 44 AS CheckId,
 				50 AS Priority,
 				'Query Problems' AS FindingGroup,
 				'Statistics Updated Recently' AS Finding,
 				'http://www.BrentOzar.com/go/stats' AS URL,
-				Details = (SELECT (SELECT Details + NCHAR(10))
+                'In the last 15 minutes, statistics were updated. To see which ones, click the HowToStopIt column.' + @LineFeed + @LineFeed
+                    + 'This effectively clears the plan cache for queries that involve these tables,' + @LineFeed
+                    + 'which thereby causes parameter sniffing: those queries are now getting brand new' + @LineFeed
+                    + 'query plans based on whatever parameters happen to call them next.' + @LineFeed + @LineFeed
+                    + 'Be on the lookout for sudden parameter sniffing issues after this time range.',
+				HowToStopIt = (SELECT (SELECT HowToStopIt + NCHAR(10))
 					FROM #UpdatedStats
 					ORDER BY RowsForSorting DESC
 					FOR XML PATH(''));
@@ -24867,7 +24872,7 @@ AS
 SET NOCOUNT ON;
 SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-SELECT @Version = '7.96', @VersionDate = '20200602';
+SELECT @Version = '7.96', @VersionDate = '20200606';
 SET @OutputType  = UPPER(@OutputType);
 
 IF(@VersionCheckMode = 1)
@@ -30051,7 +30056,7 @@ BEGIN
 SET NOCOUNT ON;
 SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-SELECT @Version = '2.96', @VersionDate = '20200602';
+SELECT @Version = '2.96', @VersionDate = '20200606';
 
 
 IF(@VersionCheckMode = 1)
@@ -31688,7 +31693,7 @@ BEGIN /*First BEGIN*/
 SET NOCOUNT ON;
 SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-SELECT @Version = '3.96', @VersionDate = '20200602';
+SELECT @Version = '3.96', @VersionDate = '20200606';
 IF(@VersionCheckMode = 1)
 BEGIN
 	RETURN;
@@ -37414,7 +37419,7 @@ BEGIN
 	SET NOCOUNT ON;
 	SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-	SELECT @Version = '7.96', @VersionDate = '20200602';
+	SELECT @Version = '7.96', @VersionDate = '20200606';
 
 	IF(@VersionCheckMode = 1)
 	BEGIN
@@ -38333,7 +38338,7 @@ SET NOCOUNT ON;
 
 /*Versioning details*/
 
-SELECT @Version = '7.96', @VersionDate = '20200602';
+SELECT @Version = '7.96', @VersionDate = '20200606';
 
 IF(@VersionCheckMode = 1)
 BEGIN

diff --git a/Install-Core-Blitz-No-Query-Store.sql b/Install-Core-Blitz-No-Query-Store.sql
@@ -37,7 +37,7 @@ AS
 	SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
 
-	SELECT @Version = '7.96', @VersionDate = '20200602';
+	SELECT @Version = '7.96', @VersionDate = '20200606';
 	SET @OutputType = UPPER(@OutputType);
 
     IF(@VersionCheckMode = 1)
@@ -9236,7 +9236,7 @@ AS
     SET NOCOUNT ON;
 	SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-	SELECT @Version = '3.96', @VersionDate = '20200602';
+	SELECT @Version = '3.96', @VersionDate = '20200606';
 
 	IF(@VersionCheckMode = 1)
 	BEGIN
@@ -11014,7 +11014,7 @@ BEGIN
 SET NOCOUNT ON;
 SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-SELECT @Version = '7.96', @VersionDate = '20200602';
+SELECT @Version = '7.96', @VersionDate = '20200606';
 
 
 IF(@VersionCheckMode = 1)
@@ -17803,7 +17803,7 @@ BEGIN
 SET NOCOUNT ON;
 SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-SELECT @Version = '7.96', @VersionDate = '20200602';
+SELECT @Version = '7.96', @VersionDate = '20200606';
 
 IF(@VersionCheckMode = 1)
 BEGIN
@@ -19870,19 +19870,19 @@ If one of them is a lead blocker, consider killing that query.'' AS HowToStopit,
 
 
     /* Query Problems - Statistics Updated Recently - CheckID 44 */
-	CREATE TABLE #UpdatedStats (Details NVARCHAR(4000), RowsForSorting BIGINT);
+	CREATE TABLE #UpdatedStats (HowToStopIt NVARCHAR(4000), RowsForSorting BIGINT);
     IF EXISTS(SELECT * FROM sys.all_objects WHERE name = 'dm_db_stats_properties')
     BEGIN
         EXEC sp_MSforeachdb N'USE [?];
-        INSERT INTO #UpdatedStats(Details, RowsForSorting)
-        SELECT Details = 
+        INSERT INTO #UpdatedStats(HowToStopIt, RowsForSorting)
+        SELECT HowToStopIt = 
                     QUOTENAME(DB_NAME()) + N''.'' +
                     QUOTENAME(SCHEMA_NAME(obj.schema_id)) + N''.'' +
                     QUOTENAME(obj.name) +
                     N'' statistic '' + QUOTENAME(stat.name) + 
                     N'' was updated on '' + CONVERT(NVARCHAR(50), sp.last_updated, 121) + N'','' + 
                     N'' had '' + CAST(sp.rows AS NVARCHAR(50)) + N'' rows, with '' +
-                    CAST(sp.rows_sampled AS NVARCHAR(50)) + N'' rows sampled, '' +  
+                    CAST(sp.rows_sampled AS NVARCHAR(50)) + N'' rows sampled,'' +  
                     N'' producing '' + CAST(sp.steps AS NVARCHAR(50)) + N'' steps in the histogram.'',
             sp.rows
         FROM sys.objects AS obj   
@@ -19894,13 +19894,18 @@ If one of them is a lead blocker, consider killing that query.'' AS HowToStopit,
     END;
 
 	IF EXISTS (SELECT * FROM #UpdatedStats)
-		INSERT INTO #BlitzFirstResults (CheckID, Priority, FindingsGroup, Finding, URL, Details)
+		INSERT INTO #BlitzFirstResults (CheckID, Priority, FindingsGroup, Finding, URL, Details, HowToStopIt)
 		SELECT 44 AS CheckId,
 				50 AS Priority,
 				'Query Problems' AS FindingGroup,
 				'Statistics Updated Recently' AS Finding,
 				'http://www.BrentOzar.com/go/stats' AS URL,
-				Details = (SELECT (SELECT Details + NCHAR(10))
+                'In the last 15 minutes, statistics were updated. To see which ones, click the HowToStopIt column.' + @LineFeed + @LineFeed
+                    + 'This effectively clears the plan cache for queries that involve these tables,' + @LineFeed
+                    + 'which thereby causes parameter sniffing: those queries are now getting brand new' + @LineFeed
+                    + 'query plans based on whatever parameters happen to call them next.' + @LineFeed + @LineFeed
+                    + 'Be on the lookout for sudden parameter sniffing issues after this time range.',
+				HowToStopIt = (SELECT (SELECT HowToStopIt + NCHAR(10))
 					FROM #UpdatedStats
 					ORDER BY RowsForSorting DESC
 					FOR XML PATH(''));
@@ -22056,7 +22061,7 @@ AS
 SET NOCOUNT ON;
 SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-SELECT @Version = '7.96', @VersionDate = '20200602';
+SELECT @Version = '7.96', @VersionDate = '20200606';
 SET @OutputType  = UPPER(@OutputType);
 
 IF(@VersionCheckMode = 1)
@@ -27240,7 +27245,7 @@ BEGIN
 SET NOCOUNT ON;
 SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-SELECT @Version = '2.96', @VersionDate = '20200602';
+SELECT @Version = '2.96', @VersionDate = '20200606';
 
 
 IF(@VersionCheckMode = 1)
@@ -28849,7 +28854,7 @@ BEGIN
 	SET NOCOUNT ON;
 	SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-	SELECT @Version = '7.96', @VersionDate = '20200602';
+	SELECT @Version = '7.96', @VersionDate = '20200606';
 
 	IF(@VersionCheckMode = 1)
 	BEGIN

diff --git a/Install-Core-Blitz-With-Query-Store.sql b/Install-Core-Blitz-With-Query-Store.sql
@@ -37,7 +37,7 @@ AS
 	SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
 
-	SELECT @Version = '7.96', @VersionDate = '20200602';
+	SELECT @Version = '7.96', @VersionDate = '20200606';
 	SET @OutputType = UPPER(@OutputType);
 
     IF(@VersionCheckMode = 1)
@@ -9236,7 +9236,7 @@ AS
     SET NOCOUNT ON;
 	SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-	SELECT @Version = '3.96', @VersionDate = '20200602';
+	SELECT @Version = '3.96', @VersionDate = '20200606';
 
 	IF(@VersionCheckMode = 1)
 	BEGIN
@@ -11014,7 +11014,7 @@ BEGIN
 SET NOCOUNT ON;
 SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-SELECT @Version = '7.96', @VersionDate = '20200602';
+SELECT @Version = '7.96', @VersionDate = '20200606';
 
 
 IF(@VersionCheckMode = 1)
@@ -17803,7 +17803,7 @@ BEGIN
 SET NOCOUNT ON;
 SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-SELECT @Version = '7.96', @VersionDate = '20200602';
+SELECT @Version = '7.96', @VersionDate = '20200606';
 
 IF(@VersionCheckMode = 1)
 BEGIN
@@ -19870,19 +19870,19 @@ If one of them is a lead blocker, consider killing that query.'' AS HowToStopit,
 
 
     /* Query Problems - Statistics Updated Recently - CheckID 44 */
-	CREATE TABLE #UpdatedStats (Details NVARCHAR(4000), RowsForSorting BIGINT);
+	CREATE TABLE #UpdatedStats (HowToStopIt NVARCHAR(4000), RowsForSorting BIGINT);
     IF EXISTS(SELECT * FROM sys.all_objects WHERE name = 'dm_db_stats_properties')
     BEGIN
         EXEC sp_MSforeachdb N'USE [?];
-        INSERT INTO #UpdatedStats(Details, RowsForSorting)
-        SELECT Details = 
+        INSERT INTO #UpdatedStats(HowToStopIt, RowsForSorting)
+        SELECT HowToStopIt = 
                     QUOTENAME(DB_NAME()) + N''.'' +
                     QUOTENAME(SCHEMA_NAME(obj.schema_id)) + N''.'' +
                     QUOTENAME(obj.name) +
                     N'' statistic '' + QUOTENAME(stat.name) + 
                     N'' was updated on '' + CONVERT(NVARCHAR(50), sp.last_updated, 121) + N'','' + 
                     N'' had '' + CAST(sp.rows AS NVARCHAR(50)) + N'' rows, with '' +
-                    CAST(sp.rows_sampled AS NVARCHAR(50)) + N'' rows sampled, '' +  
+                    CAST(sp.rows_sampled AS NVARCHAR(50)) + N'' rows sampled,'' +  
                     N'' producing '' + CAST(sp.steps AS NVARCHAR(50)) + N'' steps in the histogram.'',
             sp.rows
         FROM sys.objects AS obj   
@@ -19894,13 +19894,18 @@ If one of them is a lead blocker, consider killing that query.'' AS HowToStopit,
     END;
 
 	IF EXISTS (SELECT * FROM #UpdatedStats)
-		INSERT INTO #BlitzFirstResults (CheckID, Priority, FindingsGroup, Finding, URL, Details)
+		INSERT INTO #BlitzFirstResults (CheckID, Priority, FindingsGroup, Finding, URL, Details, HowToStopIt)
 		SELECT 44 AS CheckId,
 				50 AS Priority,
 				'Query Problems' AS FindingGroup,
 				'Statistics Updated Recently' AS Finding,
 				'http://www.BrentOzar.com/go/stats' AS URL,
-				Details = (SELECT (SELECT Details + NCHAR(10))
+                'In the last 15 minutes, statistics were updated. To see which ones, click the HowToStopIt column.' + @LineFeed + @LineFeed
+                    + 'This effectively clears the plan cache for queries that involve these tables,' + @LineFeed
+                    + 'which thereby causes parameter sniffing: those queries are now getting brand new' + @LineFeed
+                    + 'query plans based on whatever parameters happen to call them next.' + @LineFeed + @LineFeed
+                    + 'Be on the lookout for sudden parameter sniffing issues after this time range.',
+				HowToStopIt = (SELECT (SELECT HowToStopIt + NCHAR(10))
 					FROM #UpdatedStats
 					ORDER BY RowsForSorting DESC
 					FOR XML PATH(''));
@@ -22056,7 +22061,7 @@ AS
 SET NOCOUNT ON;
 SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-SELECT @Version = '7.96', @VersionDate = '20200602';
+SELECT @Version = '7.96', @VersionDate = '20200606';
 SET @OutputType  = UPPER(@OutputType);
 
 IF(@VersionCheckMode = 1)
@@ -27240,7 +27245,7 @@ BEGIN
 SET NOCOUNT ON;
 SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-SELECT @Version = '2.96', @VersionDate = '20200602';
+SELECT @Version = '2.96', @VersionDate = '20200606';
 
 
 IF(@VersionCheckMode = 1)
@@ -28877,7 +28882,7 @@ BEGIN /*First BEGIN*/
 SET NOCOUNT ON;
 SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-SELECT @Version = '3.96', @VersionDate = '20200602';
+SELECT @Version = '3.96', @VersionDate = '20200606';
 IF(@VersionCheckMode = 1)
 BEGIN
 	RETURN;
@@ -34603,7 +34608,7 @@ BEGIN
 	SET NOCOUNT ON;
 	SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
-	SELECT @Version = '7.96', @VersionDate = '20200602';
+	SELECT @Version = '7.96', @VersionDate = '20200606';
 
 	IF(@VersionCheckMode = 1)
 	BEGIN

diff --git a/sp_AllNightLog.sql b/sp_AllNightLog.sql
@@ -30,7 +30,7 @@ SET NOCOUNT ON;
 BEGIN;
 
 
-SELECT @Version = '3.95', @VersionDate = '20200602';
+SELECT @Version = '3.95', @VersionDate = '20200606';
 
 IF(@VersionCheckMode = 1)
 BEGIN

diff --git a/sp_AllNightLog_Setup.sql b/sp_AllNightLog_Setup.sql
@@ -36,7 +36,7 @@ SET NOCOUNT ON;
 
 BEGIN;
 
-SELECT @Version = '3.95', @VersionDate = '20200602';
+SELECT @Version = '3.95', @VersionDate = '20200606';
 
 IF(@VersionCheckMode = 1)
 BEGIN

diff --git a/sp_Blitz.sql b/sp_Blitz.sql
@@ -37,7 +37,7 @@ AS
 	SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
 
 
-	SELECT @Version = '7.96', @VersionDate = '20200602';
+	SELECT @Version = '7.96', @VersionDate = '20200606';
 	SET @OutputType = UPPER(@OutputType);
 
     IF(@VersionCheckMode = 1)