Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selector improvement and code cleanup #3369

Open
wants to merge 1,188 commits into
base: current
Choose a base branch
from
Open

Selector improvement and code cleanup #3369

wants to merge 1,188 commits into from

Conversation

FaySmash
Copy link

@FaySmash FaySmash commented Mar 2, 2024

Improved the download button selector and removed unused and non-functional code (still WIP)

The old code only worked on the English version of the Chrome Web Store because it searched for "Add to Chrome", which changes with different localization. I made the selector generic to work on all languages. I also found that the function parentNodeUntil doesn't get called and the browser.runtime.onMessage and browser.runtime.sendMessage don't work and also don't have any purpose (?).
The installation still doesn't work tho, also the uninit function doesn't get called so this PR isn't final but servers as a base for further improvements.

goodusername123 and others added 9 commits February 19, 2024 13:36
@FaySmash FaySmash mentioned this pull request Mar 2, 2024
Open
1 task
jamesteow and others added 20 commits March 6, 2024 15:58
@jamesteow
Bug 1879714 - Update search-telemetry-v2 schema with more functionali…
6730e7b 
…ty and loosen restrictions on component types - r=Standard8, a=dsmith

Differential Revision: https://phabricator.services.mozilla.com/D201313
@EdgarChen
Bug 1881257 - Reset mSourceTopWindowContext when drag session end; a=…
37c58e9 
…diannaS

Original Revision: https://phabricator.services.mozilla.com/D203103

Differential Revision: https://phabricator.services.mozilla.com/D204101
@emilio
Bug 1883868 - Don't fire http loads from workers. r=jfkthame, a=dsmith
2da0b9d 
Differential Revision: https://phabricator.services.mozilla.com/D203927
@CosminSabou
Bug 1883868 - Restrict new codepath to worker threads. a=dsmith
a662a9a 
So as to not change load timing from stylo threads.
@valenting
Bug 1870499 - HttpChannelChild::Release should pass itself using std:…
e8e445b 
…:move a=diannaS

Original Revision: https://phabricator.services.mozilla.com/D202796

Differential Revision: https://phabricator.services.mozilla.com/D204061
@valenting
Bug 1870499 - Break potential runnable loop in HttpChannelChild::Rele…
42e6c12 
…ase a=diannaS

Original Revision: https://phabricator.services.mozilla.com/D202797

Differential Revision: https://phabricator.services.mozilla.com/D204062
@valenting
Bug 1870499 - Make sure ContinueDoNotifyListener is called immediatel…
889f6c5 
…y during release a=diannaS

The causes of the runnable loop are as follows:
1. In Release we have a special case to make sure OnStart&OnStop are always
   called. We do this by dispatching a runnable that calls DoNotifyListener.
2. DoNotifyListener is called, then the reference to the channel is again
   dropped. But at this point only OnStartRequest was called, and
   ContinueDoNotifyListener was added to mEventQ. That means another
   runnable would be dispatched.

While the loop was broken in the previous patch, we still want to ensure
OnStopRequest is called before the channel is released, so this patch
adds an argument to DoNotifyListener to select whether ContinueDoNotifyListener
should be called synchronously or dispatched to mEventQ.

Original Revision: https://phabricator.services.mozilla.com/D202798

Differential Revision: https://phabricator.services.mozilla.com/D204063
No Bug, mozilla-esr115 repo-update HSTS HPKP remote-settings - a=repo…
cf4437d 
…-update, r=dsmith

Differential Revision: https://phabricator.services.mozilla.com/D204210
No bug - Tagging f3dd0afed51cb7283d4fa06a0c40286eee657e30 with FIREFO…
d44ebac 
…X_115_9_0esr_BUILD1 a=release CLOSED TREE DONTBUILD
@alastor0325
Bug 1861016 - some fixes. r=media-playback-reviewers,jolin, a=RyanVM
d8dc28a
No bug - Tagging 423e963b3d9b923e3c7fae8eae2f626f02c15cf2 with FIREFO…
5d2e87d 
…X_115_9_0esr_BUILD2 a=release CLOSED TREE DONTBUILD
Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release…
85d239f 
… ba=release
No Bug, mozilla-esr115 repo-update HSTS HPKP remote-settings - a=repo…
5064624 
…-update r=RyanVM

Differential Revision: https://phabricator.services.mozilla.com/D204888
@gabrielesvelto
Bug 1878428 - Prevent a deadlock while doing in-process minidump gene…
5497e9e 
…ration r=spohl a=RyanVM

This removes all the memory allocations which we were doing while writing a
minidump of the crashed process from within the process itself. Under these
conditions all threads are stopped save for the minidump writer; so if another
thread owns a mutex guarding the memory allocator we could deadlock by doing
allocations.

This patch avoids allocating strings entirely and uses Breakpad's alternative
allocator to sidestep the issue where we cannot avoid allocations.

Differential Revision: https://phabricator.services.mozilla.com/D201960
@glandium
Bug 1881370 - Upgrade ahash to 0.7.8. a=RyanVM
966af43 
Original Revision: https://phabricator.services.mozilla.com/D202361

Differential Revision: https://phabricator.services.mozilla.com/D202763
@Trikolon
Bug 1879855 - Test, r=Gijs a=test-only
7514d73
No bug - Tagging 423e963b3d9b923e3c7fae8eae2f626f02c15cf2 with FIREFO…
7b1a7bc 
…X_115_9_0esr_RELEASE a=release CLOSED TREE DONTBUILD
@serge-sans-paille @MrAlex94
Bug 1858056 - Favor RawConfigParser.read_file instead of deprecated r…
9bfb9c0 
…eadfp r=saschanaz

readfp is deprecated since Python 3.2

Differential Revision: https://phabricator.services.mozilla.com/D190532
@saschanaz @MrAlex94
Bug 1857470 - Part 2: Use pip 23.2.1 wheel in mozharness r=firefox-bu…
e6d9232 
…ild-system-reviewers,sergesanspaille

Differential Revision: https://phabricator.services.mozilla.com/D190285
@serge-sans-paille @MrAlex94
Bug 1857516 - Get rid of deprecated imp python module in favor of imp…
3cb8e78 
…ortlib r=saschanaz CLOSED TREE

Following the official migration guide from
https://docs.python.org/3/whatsnew/3.12.html#imp

Differential Revision: https://phabricator.services.mozilla.com/D190465
FaySmash and others added 2 commits March 20, 2024 18:47
@FaySmash
Selector improvement and code cleanup
cb5938a 
Improved the download button selector and removed unused and non-functional code (still WIP)

Signed-off-by: FaySmash <[email protected]>
Merge branch 'patch-4' of https://github.com/FaySmash/Waterfox into p…
9f1befd 
…atch-4
@FaySmash
Copy link
Author

Sorry for the mess in commits - if your rebase your change ontop of the latest HEAD, should get cleaned up (may require a force push to your branch).

I tested this, but when en-US remains the default, the button detection no longer works at all.

Hi Alex, thanks for getting back at me. I changed the JS Selector to identify the button to this: (document.querySelectorAll('main > div > section > section > div > div > button'))[0]

Which works in my case:
Screenshot 2024-03-20 185504
(also tested on other browsers)

As I noted, this PR is not final and still needs work (currently even if the button appears, the installation still doesn't work)

@MrAlex94 MrAlex94 force-pushed the current branch 6 times, most recently from 101edb3 to b5d6815 Compare April 17, 2024 12:21
@MrAlex94 MrAlex94 force-pushed the current branch 4 times, most recently from 34f1d0c to 6f4550f Compare May 13, 2024 17:34
@MrAlex94 MrAlex94 force-pushed the current branch 2 times, most recently from d1e5532 to e35d968 Compare July 2, 2024 12:51
@MrAlex94 MrAlex94 force-pushed the current branch 2 times, most recently from 609d205 to 902e71b Compare September 30, 2024 08:29
@MrAlex94 MrAlex94 force-pushed the current branch 3 times, most recently from e282bf2 to 491e67c Compare October 15, 2024 11:34
@MrAlex94 MrAlex94 force-pushed the current branch 2 times, most recently from f2265da to f979615 Compare October 30, 2024 11:45
@MrAlex94 MrAlex94 force-pushed the current branch 3 times, most recently from a1ed67a to ce52f0e Compare November 8, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.