Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the blanket implementation for reference of Automaton #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

momvart
Copy link

@momvart momvart commented Nov 16, 2024

Fixes #149

@momvart momvart marked this pull request as draft November 16, 2024 00:13
@momvart
Copy link
Author

momvart commented Nov 16, 2024

(As removing the implementation is presumably a breaking change, I put it in a separate commit so you have an easier job not merging it.)

@momvart momvart marked this pull request as ready for review November 16, 2024 00:27
@BurntSushi
Copy link
Owner

The main thing preventing merging here is a manual inspection of cargo bloat (or similar tool) to confirm that there aren't extra copies of the internal search routines.

@momvart
Copy link
Author

momvart commented Nov 18, 2024

The main thing preventing merging here is a manual inspection of cargo bloat (or similar tool) to confirm that there aren't extra copies of the internal search routines.

I see. If you can give me some instructions on what data you want to collect, I can help with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary referencing may cause infinite recursion in compilation
2 participants