Add benchmarks of 'write_[u]int[128]' #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fintelia
commented
Apr 2, 2024
| @@ -18,7 +18,7 @@ macro_rules! bench_num { | |||
| let buf = $data; | |||
| b.iter(|| { | |||
| for _ in 0..NITER { | |||
| bb(BigEndian::$read(&buf, $bytes)); | |||
| bb(BigEndian::$read(&buf, bb($bytes))); | |||
There was a problem hiding this comment.
Not sure whether the $bytes input should be wrapped in black_box, but I noticed it has a huge impact on performance, so I figured I'd mention it
There was a problem hiding this comment.
Hmmm I don't think so. But I'm honestly not sure. I'd have to see a minimal reproducible example and compare codegen I think.
There was a problem hiding this comment.
I think I would defer to the status quo for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds benchmarks of other crate methods that previously weren't benchmarked.