Skip to content

Commit

Permalink
Update comment to use View naming convention
Browse files Browse the repository at this point in the history
  • Loading branch information
NereusWB922 committed Mar 14, 2024
1 parent 27faa65 commit b7d422e
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/app/core/models/issue.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export class Issue {
author: string;
isDraft: boolean;

/** Depending on the phase, assignees attribute can be derived from Github's assignee feature OR from the Github's issue description */
/** Depending on the view, assignees attribute can be derived from Github's assignee feature OR from the Github's issue description */
assignees?: string[];
labels?: string[];
githubLabels?: GithubLabel[];
Expand Down
2 changes: 1 addition & 1 deletion src/app/issues-viewer/issues-viewer.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export class IssuesViewerComponent implements OnInit, AfterViewInit, OnDestroy {
}

/**
* Checks if our current repository available on phase service is indeed a valid repository
* Checks if our current repository available on view service is indeed a valid repository
*/
private checkIfValidRepository() {
const currentRepo = this.viewService.currentRepo;
Expand Down
4 changes: 2 additions & 2 deletions tests/app/core/models/session-model.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ describe('Session Model', () => {
});
});

it('should throw error on session with invalid phases', () => {
of({ sessionRepo: [{ view: 'invalidPhase' as View, repos: [WATCHER_REPO] }] })
it('should throw error on session with invalid views', () => {
of({ sessionRepo: [{ view: 'invalidView' as View, repos: [WATCHER_REPO] }] })
.pipe(assertSessionDataIntegrity())
.subscribe({
next: () => fail(),
Expand Down
2 changes: 1 addition & 1 deletion tests/constants/label.constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export const LIGHT_BG_DARK_TEXT = {
color: `#${COLOR_BLACK}`
};

// Constant array of labels for team response phase and moderation phase to simulate Github response
// Constant array of labels for team response view and moderation view to simulate Github response
export const SEVERITY_LABELS = [
{
name: LABEL_NAME_SEVERITY_VERY_LOW,
Expand Down
6 changes: 3 additions & 3 deletions tests/services/view.service.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ describe('ViewService', () => {
expect(currentSessionRepo?.repos).toEqual([WATCHER_REPO, CATCHER_REPO]);
});

it('should store phase details via githubService and update localStorage', () => {
it('should store view details via githubService and update localStorage', () => {
const localStorageSetItem = spyOn(localStorage, 'setItem');

viewService.setRepository(WATCHER_REPO);
Expand Down Expand Up @@ -127,8 +127,8 @@ describe('ViewService', () => {
});
});

describe('changeView(Phase)', () => {
it('should set current phase', () => {
describe('changeView(View)', () => {
it('should set current view', () => {
viewService.setRepository(WATCHER_REPO);

expect(viewService.currentView).toEqual(View.issuesViewer);
Expand Down

0 comments on commit b7d422e

Please sign in to comment.