Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sorting by assignees in Issue Sorter #286

Merged
merged 9 commits into from
Mar 12, 2024
Merged

Remove sorting by assignees in Issue Sorter #286

merged 9 commits into from
Mar 12, 2024

Conversation

MadLamprey
Copy link
Contributor

Summary:

Fixes #280

Changes Made:

  • Remove sorting by assignees in issue-sorter.ts
  • Remove test cases for sorting by assignees in issue-sorter.spec.ts

Proposed Commit Message:

Remove sorting by assignees in Issue Sorter

Issue columns are already sorted by assignees in WATcher. 

Let's remove sorting by assignees from the Issue Sorter to reduce redundancy.

Arif-Khalid
Arif-Khalid reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@Arif-Khalid Arif-Khalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An excellent refactor! Aside from small unrelated change that should be in a separate PR.

package.json Outdated
@@ -5,7 +5,7 @@
"scripts": {
"ng": "ng",
"build:staging": "npm run codegen:gql && ng build --c staging --base-href=https://catcher-org.github.io/WATcher-staging/",
"build:prod:web": "npm run codegen:gql && ng build --prod --base-href=https://CATcher-org.github.io/WATcher/",
"build:prod:web": "npm run codegen:gql && ng build --prod --base-href=https://catcher-org.github.io/WATcher/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this in unrelated to the current PR, could you create an issue and make this change in a separate PR?

gycgabriel
gycgabriel previously approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@gycgabriel gycgabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fix Arif's comment

gycgabriel
gycgabriel approved these changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@gycgabriel gycgabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@MadLamprey MadLamprey merged commit 7e68bbd into CATcher-org:main Mar 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arif-Khalid Arif-Khalid Arif-Khalid left review comments

@gycgabriel gycgabriel gycgabriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove sorting by assignees in Issue Sorter
3 participants
@MadLamprey @gycgabriel @Arif-Khalid