Deploy v1.1.1 #292
Merged
Deploy v1.1.1 #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making releases is done via a manual call to Version Deployment workflow This can be further streamlined by deployment on push to a deploy branch Let's change workflow behavior to run on push to a deploy branch
Title filter is handled outside of filters service This violates the responsibility of the filters service Let's refactor the search filter to use the filters service
Npm run test will break if the import statement for zone-testing is not at the top of test.ts file. Let's reorder the import statement and disable tslint rule for test.ts file.
The method in issue sorter has been updated. Let's refactor the test cases to match the changes.
The test cases for the user service are outdated. Let's refactor test cases for user service.
The test cases for the label filter bar component are outdated. Let's refactor test cases for label filter bar component
Refactor and add test cases for phase service Phase service has been updated. Let's refactor and add test cases to match the changes.
pre-push hook that runs `npm run test` automatically ensures all tests pass locally, enhancing code quality and preventing the accidental push of failing code. Let's enable the pre-push hook.
We store milestones by number. This works when filters are confined to one repo, but doesn't make sense when saving filters across repos. Let's refactor the milestones to save by title instead of number
Co-authored-by: Misra Aditya <[email protected]>
gycgabriel
added a commit
that referenced
this pull request
Mar 14, 2024
This reverts commit 263426a.
Closed
NereusWB922
added a commit
to NereusWB922/WATcher
that referenced
this pull request
Mar 31, 2024
This reverts commit 263426a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Type of change:
(Delete where appropriate)
Changes Made:
Screenshots:
(If applicable, provide screenshots or GIFs to visually demonstrate the changes.)
Proposed Commit Message:
Checklist: