Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable url redirect for activity dashboard #294

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

NereusWB922
Copy link
Contributor

@NereusWB922 NereusWB922 commented Mar 14, 2024

Summary:

Fixes #278

Type of change:

  • ✨ Enhancement

Changes Made:

  • Add private method to navigate with current phase and repos
  • Handle navigation in changePhase method
  • Implement general phase validation
  • Set phase in setupFromUrl
  • Implement activity dashboard reload on repo change
  • Add test case to verify the navigating behavior of changePhase method

Proposed Commit Message:

Enable URL redirect for other views

URL redirect currently only works for issueViewer. It is a useful feature
that improves user experience.

Let's implement a general URL redirect that works for other views as well.

@NereusWB922 NereusWB922 force-pushed the 278-enable-url-redirect-activity-dashboard branch from eb0d3b5 to 8b49cae Compare March 14, 2024 08:41
Copy link
Contributor

@nknguyenhc nknguyenhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

A quick test shows that in activity dashboard, upon choosing a new repo, the dashboard is not refreshed.

@NereusWB922
Copy link
Contributor Author

image

A quick test shows that in activity dashboard, upon choosing a new repo, the dashboard is not refreshed.

Thanks for the review! I just fixed this.

@NereusWB922 NereusWB922 force-pushed the 278-enable-url-redirect-activity-dashboard branch 4 times, most recently from 933dc75 to 5fc6267 Compare March 20, 2024 15:04
@NereusWB922 NereusWB922 force-pushed the 278-enable-url-redirect-activity-dashboard branch from 5fc6267 to 3abe8c8 Compare March 24, 2024 00:27
@NereusWB922 NereusWB922 marked this pull request as draft April 16, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make URL redirect to work with activity dashboard
2 participants