Integrate Grouping Service #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NereusWB922
force-pushed
the
306-integrate-grouping-service
branch
from
d912df4
to
930e88e
Compare
NereusWB922
force-pushed
the
306-integrate-grouping-service
branch
from
930e88e
to
62a1bbf
Compare
Arif-Khalid
reviewed
Mar 25, 2024
There was a problem hiding this comment.
An excellent PR which lays the groundwork for switching by group. Perhaps the currGroupBy variable could be stored and updated as a filter since I would consider it a filter variable. This would reduce duplicated code for enhancements regarding filters such as storing filters in the url. I will create an issue for discussion not to be implemented in this PR.
Also a minor complaint about naming, but otherwise a great implementation which no doubt took a lot of work! 😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes part of #306
Type of change:
Changes Made:
IssueDataTableto useGroupingContextServicefor data groupingIssueViewerComponentto useGroupingContextServicefor groupingCardViewComponentto render dynamic header for differentGrouptypeHiddenUsersComponentto render differentGrouptypeFilterBarComponentProposed Commit Message: