Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement group by milestone #316

Conversation

NereusWB922
Copy link
Contributor

Summary:

Fixes #306

Type of change:

  • ✨ New Feature/ Enhancement

Changes Made:

  • Refactor Milestone model to implement Group interface
  • Implement MilestoneGroupingStrategy
  • Include Milestone grouping in GroupingContextService
  • Add card view header template for Milestone grouping
  • Add hidden groups card template for Milestone grouping

Proposed Commit Message:

Implement "Group by Milestone"

WATcher's default view displays issues and pull requests based solely on
their assignees. Grouping issues and pull requests based on their
associated milestones may provide another useful view for the user.

Let's implement the "Group by Milestone" feature.

Copy link
Contributor

@nknguyenhc nknguyenhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Clean implementation of the grouping context service and the milestone grouping strategy.

@NereusWB922 NereusWB922 merged commit cd4614f into CATcher-org:main Mar 29, 2024
3 checks passed
@NereusWB922 NereusWB922 deleted the 306-implement-milestone-grouping-strategy branch March 29, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GroupBy Feature
2 participants