Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo on back and forward navigation #322

Merged

Conversation

NereusWB922
Copy link
Contributor

Summary:

Fixes #321

Type of change:

  • 🐛 Bug Fix

Changes Made:

  • Implement method to initialize repo from url params
  • Call it when encounter popstate event (when back or forward button clicked)

Proposed Commit Message:

Update repository on back and forward navigation.

IssueViewer's repository is not updated when navigating back or forward
in the URL history. This will lead to inconsistency between the URL
parameters and the application state.

Let's ensure that IssueViewer's repository is updated on back and forward
navigation.

Copy link
Contributor

@Arif-Khalid Arif-Khalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@nknguyenhc nknguyenhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NereusWB922 NereusWB922 merged commit 2eb2aba into CATcher-org:main Mar 29, 2024
3 checks passed
@NereusWB922 NereusWB922 deleted the 321-update-repo-on-navigation branch March 29, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update IssueViewer's Repo on Back/Forward Navigation
3 participants