Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MilestoneGroupingStrategy to match the changes in #315 #323

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Refactor MilestoneGroupingStrategy to match the changes in #315 #323

merged 1 commit into from
Mar 29, 2024

Conversation

NereusWB922
Copy link
Contributor

Summary:

As title.

Type of change:

  • 🎨 Code Refactoring

Changes Made:

  • Include IssueWithoutMilestone and PRWithoutMilestone in the list return by getGroups

Proposed Commit Message:

Refactor MilestoneGroupingStrategy to match the changes in #315.

Special milestone groups are not added in the parseMilestoneData
method.

Let's add the special milestone groups to the result of the getGroups
method.

nknguyenhc
nknguyenhc approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@nknguyenhc nknguyenhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NereusWB922 NereusWB922 merged commit 70bae91 into CATcher-org:main Mar 29, 2024
3 checks passed
@NereusWB922 NereusWB922 deleted the include-pr-issue-with-no-milestone-group branch March 29, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nknguyenhc nknguyenhc nknguyenhc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NereusWB922 @nknguyenhc