Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset GroupingContextService only if "keep filter" is selected. #324

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Reset GroupingContextService only if "keep filter" is selected. #324

merged 1 commit into from
Mar 29, 2024

Conversation

NereusWB922
Copy link
Contributor

Summary:

Fix the bug where GroupingContextService is reset when the keep filter option is selected.

Type of change:

  • 🐛 Bug Fix

Changes Made:

  • Add if block to check if keep filter option is selected before resetting

Proposed Commit Message:

Reset GroupingContextService only if "keep filter" is selected.

GroupingContextService is being reset when the "keep filter" 
option is selected.

Let's check if the "keep filter" option is selected before
resetting the service.

Arif-Khalid
Arif-Khalid approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@Arif-Khalid Arif-Khalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NereusWB922 NereusWB922 merged commit 8ddcdcd into CATcher-org:main Mar 29, 2024
3 checks passed
@NereusWB922 NereusWB922 deleted the fix-keep-filter-groupby-issue branch March 29, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arif-Khalid Arif-Khalid Arif-Khalid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NereusWB922 @Arif-Khalid