Deploy V1.2.0 #331
Merged
Deploy V1.2.0 #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making releases is done via a manual call to Version Deployment workflow This can be further streamlined by deployment on push to a deploy branch Let's change workflow behavior to run on push to a deploy branch
Title filter is handled outside of filters service This violates the responsibility of the filters service Let's refactor the search filter to use the filters service
Npm run test will break if the import statement for zone-testing is not at the top of test.ts file. Let's reorder the import statement and disable tslint rule for test.ts file.
The method in issue sorter has been updated. Let's refactor the test cases to match the changes.
The test cases for the user service are outdated. Let's refactor test cases for user service.
The test cases for the label filter bar component are outdated. Let's refactor test cases for label filter bar component
Refactor and add test cases for phase service Phase service has been updated. Let's refactor and add test cases to match the changes.
pre-push hook that runs `npm run test` automatically ensures all tests pass locally, enhancing code quality and preventing the accidental push of failing code. Let's enable the pre-push hook.
We store milestones by number. This works when filters are confined to one repo, but doesn't make sense when saving filters across repos. Let's refactor the milestones to save by title instead of number
Co-authored-by: Misra Aditya <[email protected]>
Changelogs are not properly formatted by release-drafter when making new releases. This is prone to human error and wastes developer resources. Let's follow the example of CATcher and implement release changelog automation for WATcher.
No way to keep filters when changing repos. An option to keep the common filters will be useful for anyone managing multiple repositories without the hassle of reapplying the same filters. Let's add a checkbox to the change repo dialog allowing users to keep their filters.
The concept of "Phase" is inherited from CATcher. Instead of "Phase", WATcher provides different "Views" of contributions in a repository. Let's replace "Phase" with "View".
Column pagination arrows cause unnecessary clogs if they are disabled. We hide arrows on columns that only has one page.
Currently, there is no tool tip for the Hidden Users mat-card. It is not immediately obvious what the column is referring to. Let's add a tool tip to make it more explanatory. Co-authored-by: Misra Aditya <[email protected]>
Implement GroupBy feature to allow users to group the issues/prs based on different criteria such as milestone, status and etc. Let's set up the Grouping Strategy and Service.
Previously, each label only has 2 states, either selected or not selected. However, with such design, the feature of hiding labels can be confused with hiding issues/PRs with the label. We implement the three-state label filters, so that each label can also be used to hide issues/PRs with the label.
We implement checkboxes for status, so that multiple types of PRs/issues can be viewed concurrently.
Co-authored-by: Misra Aditya <[email protected]>
Co-authored-by: Misra Aditya <[email protected]>
Implement GroupBy feature to allow users to group the issues/prs based on different criteria such as milestone, status and etc. Let's integrate the grouping service in the components.
Milestones are not saved even when filters are kept. This is inconsistent with the meaning of keeping filters. Let's implement keeping milestones across repos.
WATcher's default view displays issues and pull requests based solely on their assignees. Grouping issues and pull requests based on their associated milestones may provide another useful view for the user. Let's implement the "Group by Milestone" feature.
Co-authored-by: Misra Aditya <[email protected]> Co-authored-by: Nguyen <[email protected]>
With groupby parameters in the URL, users can easily share the current grouping by using the URL. Let's implement initialization with URL parameters and the ability to set groupby parameters.
Co-authored-by: Misra Aditya <[email protected]> Co-authored-by: nknguyenhc <[email protected]>
Currently, there are a lot of options of filters, but there are no suggested useful preset views. We add preset views for users to choose from, and via a button on the header.
…her-org#324) GroupingContextService is being reset when the "keep filter" option is selected. Let's check if the "keep filter" option is selected before resetting the service.
…g#315 (CATcher-org#323) Special milestone groups are not added in the parseMilestoneData method. Let's add the special milestone groups to the result of the getGroups method.
IssueViewer's repository is not updated when navigating back or forward in the URL history. This will lead to inconsistency between the URL parameters and the application state. Let's ensure that IssueViewer's repository is updated on back and forward navigation.
When there are no milestones in the repo, the issue viewer shows nothing. Change is made so that if there is no milestone in the milestone service, do not apply the milestone filter.
Enabling automate testing in GitHub Actions with enhanced code quality of the codebase. Let's enable automate testing.
Filters cannot be shared to among users. Users might want to share their current view to others, consisting of their current filters. Let's pull and store filters in the URL to allow sharing of filter combinations.
This reverts commit 263426a.
Arif-Khalid
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As title.
Changes Made:
Proposed Commit Message: