Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide column issue count #346

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

nknguyenhc
Copy link
Contributor

Summary:

Fixes #343

Type of change:

  • ✨ New Feature/ Enhancement

Changes Made:

  • Make each card a vertical flex box
  • Shift the scrolling from .scrollable-container to .scrollable-container-wrapper
  • Make the .scrollable-container-wrapper to flex grow.

Screenshots:

image

Proposed Commit Message:

Hide column issue count

We hide the issue column count when there is only one page,
to make space for the issues.

Checklist:

  • I have tested my changes thoroughly.
  • I have created tests for any new code files created in this PR or provided a link to a issue/PR that addresses this.
  • I have added or modified code comments to improve code readability where necessary.
  • I have updated the project's documentation as necessary.

Copy link
Contributor

@NereusWB922 NereusWB922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nknguyenhc nknguyenhc merged commit d356fbe into CATcher-org:main Apr 3, 2024
3 checks passed
@damithc
Copy link
Contributor

damithc commented Apr 3, 2024

@nknguyenhc my expectation was:
image

Separately, feels like showing items per page in every column (even when there are multiple pages) is redundant (and hard to use as well). Not sure how to solve it though.

@Arif-Khalid Arif-Khalid mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide column issue count if only one page
3 participants