Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement filter for Task Owners #381

Merged
merged 8 commits into from
Jul 20, 2024

Conversation

kokerinks
Copy link
Contributor

@kokerinks kokerinks commented Jul 7, 2024

Summary:

In this context, we define a Task owner as follows:

  • For an issue, task owner refers to the members assigned that issue
  • For a pull request, task owner refers to the author/creator of the PR

Fixes #342

Type of change:

  • ✨ New Feature/ Enhancement

Changes Made:

  • Implemented a new filter which filters issues/PRs based on a Task Owner, i.e.:
    • Author/creator for PRs
    • Assignees for issues

Screenshots:

image

Proposed Commit Message:

Implement filter for Task Owners

Having a function to filter issues/PRs by task owners can 
give users a more organised overview of the contributions
made by each member in the project. 

Hence, let's add it to the list of existing filters we have 
currently for users.

Checklist:

  • I have tested my changes thoroughly.
  • I have created tests for any new code files created in this PR or provided a link to a issue/PR that addresses this.
  • I have added or modified code comments to improve code readability where necessary.
  • I have updated the project's documentation as necessary.

@kokerinks kokerinks changed the title Assignee filter Implement filter for assignees Jul 8, 2024
@kokerinks kokerinks changed the title Implement filter for assignees Implement filter for Task Owners Jul 16, 2024
@kokerinks kokerinks marked this pull request as ready for review July 16, 2024 06:13
Copy link
Contributor

@NereusWB922 NereusWB922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, just one minor comment. Other than that, everything look good.

src/app/core/services/assignee.service.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@NereusWB922 NereusWB922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NereusWB922
Copy link
Contributor

@kokerinks Approved. You can merge it when you are ready

@kokerinks
Copy link
Contributor Author

@NereusWB922 can you help to merge this please? I dont have enough write access :')

@NereusWB922 NereusWB922 merged commit 610fa8d into CATcher-org:main Jul 20, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add filter for assignee
2 participants