Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor groups functionalities out of issues-viewer as a service #384

Merged
merged 17 commits into from
Aug 3, 2024
Merged

Refactor groups functionalities out of issues-viewer as a service #384

merged 17 commits into from
Aug 3, 2024

Conversation

kokerinks
Copy link
Contributor

@kokerinks kokerinks commented Jul 23, 2024 •
edited
Loading

Summary:

Fixes #383

Type of change:

  • 🎨 Code Refactoring

Changes Made:

  • Refactored all code relevant to group-handling into a new service group.service.ts within the services/grouping folder

Proposed Commit Message:

Currently, the issues-viewer component contains the fields and functions
tracking the groups to be shown and hidden.

Let's refactor out these functionalities into a new service to ensure 
better separations of concerns.

Checklist:
  • I have tested my changes thoroughly.
  • I have created tests for any new code files created in this PR or provided a link to a issue/PR that addresses this.
  • I have added or modified code comments to improve code readability where necessary.
  • I have updated the project's documentation as necessary.

@kokerinks
Copy link
Contributor Author

@NereusWB922 Can i get your help to review this when you're free? Thanks!

@kokerinks kokerinks marked this pull request as draft July 24, 2024 07:23
@kokerinks kokerinks marked this pull request as ready for review July 24, 2024 07:24
NereusWB922
NereusWB922 requested changes Jul 27, 2024
View reviewed changes
Copy link
Contributor

@NereusWB922 NereusWB922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kokerinks, thanks for the refactoring. I left some comments; please let me know if you have any questions.

src/app/issues-viewer/issues-viewer.component.ts Outdated Show resolved Hide resolved
src/app/core/services/grouping/group.service.ts Show resolved Hide resolved
src/app/issues-viewer/issues-viewer.component.ts Show resolved Hide resolved
@kokerinks
Copy link
Contributor Author

@NereusWB922 Can merge when you're ready! thanks for the review 🙏

@NereusWB922 NereusWB922 merged commit c5999bf into CATcher-org:main Aug 3, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NereusWB922 NereusWB922 NereusWB922 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor groups functionalities out of issues-viewer as a service
2 participants
@kokerinks @NereusWB922