-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRDCDH-1743 Implement "Request Access" form #499
Conversation
Pull Request Test Coverage Report for Build 11598672571Details
💛 - Coveralls |
NOTE: The additional input field has a false-positive 508 issue. This is the same issue that is described here #510. However, because this field does need to be multi-line, I can't find a solution for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything LGTM! I like the centralized styled components for the dialog. Thanks for adding that. I don't have any actual requested changes, just some comments.
Skipping re-review, a merge commit dismissed the previous approval. |
Overview
This PR introduces a new feature for external users (User, Submitter, Org Owner) to request a role and/or organization change via their profile.
It also incorporates related DX QoL changes. See details below.
Note
I added a "StyledDialogComponents" folder, but did not migrate any existing dialogs to these prestyled components. If we get related work (bugs/tasks) for the dialogs, we can probably migrate them at that point.
Most of the dialogs have the same general design, with the exception of width and content-specific customizations. If it doesn't make sense to have a centralized set of components, I can remove this folder.
Related note – I left the explicit font specification on the dialog components, if any dialog can appear on the Model Navigator page (eg. CLI Tool dialog), Model Navigator will try to override our default Nunito font.
Warning
This PR has several tests that refuse to pass in CI consistently. I plan to revisit this in #511 as I'm unsure what the root issue is ATM.
Change Details (Specifics)
Related Ticket(s)
CRDCDH-1743 (Task)