Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-1843 Remove size from Batch #518

Open
wants to merge 2 commits into
base: 3.2.0
Choose a base branch
from
Open

CRDCDH-1843 Remove size from Batch #518

wants to merge 2 commits into from

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Oct 31, 2024

Overview

This PR primarily removes the size parameter from the createBatch API, but also removes any reference to it elsewhere (it wasn't ever visually rendered anyway). Includes some directly related changes also.

Change Details (Specifics)

  • Define a createBatch input type and implement it accordingly
  • Remove (now) unused FileInput type
  • Constrain BatchFileInfo to a set of strings
  • Add Logger util for when createBatch fails

Related Ticket(s)

CRDCDH-1843 (FE Task)
CRDCDH-1835 (BE Task)

@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Oct 31, 2024
@amattu2 amattu2 added this to the 3.2.0 (PMVP-M3) milestone Oct 31, 2024
@coveralls
Copy link
Collaborator

coveralls commented Oct 31, 2024

Pull Request Test Coverage Report for Build 11842275835

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 53.816%

Totals Coverage Status
Change from base Build 11823614446: 0.004%
Covered Lines: 3690
Relevant Lines: 6361

💛 - Coveralls

@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Nov 7, 2024
@amattu2 amattu2 marked this pull request as ready for review November 14, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants