Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for Python 3.8 thru 3.12 #1165

Merged
merged 42 commits into from
Mar 19, 2024

Conversation

franflame
Copy link
Contributor

Summary/Motivation:

Testing whether FOQUS works with Python 3.10 and 3.11

Changes proposed in this PR:

Adding Python 3.10 and 3.11 to CI checks

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 38.52%. Comparing base (9faf1d8) to head (6432fba).
Report is 1 commits behind head on master.

Files Patch % Lines
foqus_lib/gui/ouu/ouuSetupFrame.py 50.00% 2 Missing ⚠️
foqus_lib/framework/uq/Plotter.py 0.00% 1 Missing ⚠️
foqus_lib/gui/flowsheet/drawFlowsheet.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1165      +/-   ##
==========================================
+ Coverage   38.32%   38.52%   +0.20%     
==========================================
  Files         163      163              
  Lines       36852    36872      +20     
  Branches     5994     6107     +113     
==========================================
+ Hits        14123    14205      +82     
+ Misses      21610    21553      -57     
+ Partials     1119     1114       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lbianchi-lbl
Copy link
Contributor

The pytest failures for Python 3.10 on Linux seem to be the same as the errors mentioned here: #1036 (comment)

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Sep 12, 2023
ksbeattie
ksbeattie previously approved these changes Mar 12, 2024
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbianchi-lbl lbianchi-lbl force-pushed the python_3.11_testing branch 2 times, most recently from 247fac5 to 72b3df4 Compare March 15, 2024 21:30
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbianchi-lbl lbianchi-lbl changed the title Python 3.11 testing Enable support for Python 3.8 thru 3.12 Mar 19, 2024
@lbianchi-lbl lbianchi-lbl marked this pull request as ready for review March 19, 2024 19:51
@ksbeattie ksbeattie marked this pull request as ready for review March 19, 2024 19:51
@ksbeattie ksbeattie enabled auto-merge (squash) March 19, 2024 19:51
@ksbeattie ksbeattie merged commit 820bbdb into CCSI-Toolset:master Mar 19, 2024
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High High Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants