Additional fixes for screen readers in main navigation and login.

CDLUC3 · Nov 15, 2024 · d67a6ce · d67a6ce
1 parent ba50e5c
commit d67a6ce
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/templates/includes/login-modal.html b/templates/includes/login-modal.html
@@ -2,7 +2,7 @@
 <div id="js-login-modal" class="login-modal" aria-hidden="true" role="dialog" aria-labelledby="login-modal__title">
   <div class="login-modal__header">
     <div id="login-modal__title" class="login-modal__title">Access your account</div>
-    <a href="" aria-label="close">
+    <a href="" aria-label="Close login modal" role="button">
       <img id="js-login-modal__close" src="/static/images/icon_cross.svg" class="login-modal__close" alt="close">
     </a>
   </div>

diff --git a/templates/includes/top.html b/templates/includes/top.html
@@ -25,7 +25,7 @@
 
   <nav role="navigation" id="js-header__nav" class="header__nav--selected" aria-hidden="false">
     <a class="header__nav-item-search" href="/search">Search</a>
-    <details id="header__nav-details-learn" aria-expanded="false">
+    <details id="header__nav-details-learn" aria-expanded="false" aria-label="Learn about EZID">
       <summary class="header__nav-item-learn" role="button">Learn</summary>
       <div class="header__subnav-panel">
         <a class="header__nav-subitem" href="{% url "ui_home.learn" %}#01">What Is EZID?</a>
@@ -45,7 +45,10 @@
           <button class="header__loginout-link" aria-label="Logout">Logout</button>
         </form>
       {% else %}
-      <button id="js-header__loginout-button" class="header__loginout-link" aria-label="Login">Login</button>
+      <button id="js-header__loginout-button" class="header__loginout-link" aria-label="Login" aria-haspopup="dialog"
+          aria-controls="js-login-modal">
+        Login
+      </button>
       {% endif %}
       {% include "includes/login-modal.html" %}
     </div>