drop unused clearing

CEED · Jul 7, 2023 · c728f78 · c728f78
1 parent 4f78e47
commit c728f78
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/interface/ceed-basis.c b/interface/ceed-basis.c
@@ -1542,8 +1542,6 @@ int CeedBasisApplyAtPoints(CeedBasis basis, CeedInt num_points, CeedTransposeMod
       {
         CeedScalar tmp[2][num_comp * CeedIntPow(Q_1d, dim)], chebyshev_x[Q_1d];
 
-        // ---- Clear output array
-        for (CeedInt i = 0; i < num_points * num_comp; i++) v_array[i] = 0.0;
         // ---- Values at point
         for (CeedInt p = 0; p < num_points; p++) {
           CeedInt pre = num_comp * CeedIntPow(Q_1d, dim - 1), post = 1;

diff --git a/tests/t352-basis.c b/tests/t352-basis.c
@@ -52,7 +52,7 @@ int main(int argc, char **argv) {
         CeedScalar coord[dim];
 
         for (CeedInt d = 0; d < dim; d++) coord[d] = x_array[d * p_dim + i];
-        for (CeedInt c = 0; c < num_comp; c++) u_array[i * num_comp + c] = Eval(dim, c + 1, coord);
+        for (CeedInt c = 0; c < num_comp; c++) u_array[i + c * p_dim] = Eval(dim, c, coord);
       }
       CeedVectorRestoreArrayRead(x_nodes, &x_array);
       CeedVectorSetArray(u, CEED_MEM_HOST, CEED_COPY_VALUES, (CeedScalar *)&u_array);
@@ -77,16 +77,16 @@ int main(int argc, char **argv) {
 
         for (CeedInt d = 0; d < dim; d++) coord[d] = x_array[d + i * dim];
         for (CeedInt c = 0; c < num_comp; c++) {
-          CeedScalar fx = Eval(dim, c + 1, coord);
-        if (fabs(v_array[i * num_comp + c] - fx) > 1E-4) {
-          // LCOV_EXCL_START
-          printf("[%" CeedInt_FMT ", %" CeedInt_FMT "] %f != %f = f(%f", dim, c, v_array[i * num_comp + c], fx, coord[0]);
-          for (CeedInt d = 1; d < dim; d++) printf(", %f", coord[d]);
-          puts(")");
-          // LCOV_EXCL_STOP
+          CeedScalar fx = Eval(dim, c, coord);
+          if (fabs(v_array[c + i * num_comp] - fx) > 1E-4) {
+            // LCOV_EXCL_START
+            printf("[%" CeedInt_FMT ", %" CeedInt_FMT "] %f != %f = f(%f", dim, c, v_array[c + i * num_comp], fx, coord[0]);
+            for (CeedInt d = 1; d < dim; d++) printf(", %f", coord[d]);
+            puts(")");
+            // LCOV_EXCL_STOP
+          }
         }
       }
-}
       CeedVectorRestoreArrayRead(x_points, &x_array);
       CeedVectorRestoreArrayRead(v, &v_array);
     }