Unify single and double precision avx backend code
#1254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiangrimberg
force-pushed
the
sjg/avx-backend-unify
branch
from
954d17b
to
c8a5553
Compare
|
Unfortunately, since this is a branch on your fork, our GitLab CI cannot run in this PR. But that's where the single precision tests occur. |
jeremylt
reviewed
Jul 12, 2023
| @@ -36,11 +36,6 @@ static int CeedTensorContractApply_Ref(CeedTensorContract contract, CeedInt A, C | |||
| return CEED_ERROR_SUCCESS; | |||
| } | |||
|
|
|||
| //------------------------------------------------------------------------------ | |||
There was a problem hiding this comment.
This is here intentionally - this isn't needed for functionality but the ref backend is the "example" other people can use to make their own backend, so I kept this in as in example.
|
Closing in favor of #1255. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the
xsmmbackend done in #1248, this removes duplicate code between thefp64andfp32implementations.