fluids: Remove ComputeL2Projection function #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylt
approved these changes
Jul 13, 2023
|
Not sure what's causing the ICC IFort test to fail (or the backend codecov), but everything else passes fine. |
jrwrigh
force-pushed
the
jrwrigh/remove_l2_proj_func
branch
from
ba9fe03
to
84d495d
Compare
|
Well, I tried to run it again and the ICC IFort test still fails... Looks like it's just the IFort compiler that can't get installed on the container correctly. Also the codecov backends even though I haven't changed anything on the backend... Regardless, whoever is able to can go ahead and merge this. |
- It's superseded by using `NodalProjectionData` + `ApplyCeedOperator*` + `KSPSolve`
jrwrigh
force-pushed
the
jrwrigh/remove_l2_proj_func
branch
from
84d495d
to
9fcc926
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodalProjectionDatastruct +ApplyCeedOperator*+KSPSolveApplyCeedOperatorGlobalToGlobal,ApplyCeedOperatorLocalToGlobal, orApplyCeedOperatorGlobalToLocaldepending on what's the most efficient for a specific application.