Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change os.path to pathlib and simplify parsing #1263

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Change os.path to pathlib and simplify parsing #1263

merged 2 commits into from
Jul 20, 2023

Conversation

zatkins-dev
Copy link
Collaborator

This PR updates junit.py to be more similar to Ratel's junit.py by

  1. Replacing os.path with pathlib.Path
  2. Replacing some nested list data structures with a TestSpec dataclass
  3. Various logic simplifications to improve code readability

@zatkins-dev zatkins-dev self-assigned this Jul 19, 2023
@zatkins-dev zatkins-dev merged commit 372821a into main Jul 20, 2023
26 checks passed
@zatkins-dev zatkins-dev deleted the zach/update-junit branch July 20, 2023 01:26
zatkins-dev added a commit that referenced this pull request Jul 28, 2023
@zatkins-dev
Change os.path to pathlib and simplify parsing (#1263)
5670913 
* Change os.path to pathlib and simplify parsing

* support for testargs without parens/name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremylt jeremylt jeremylt approved these changes

Assignees

@zatkins-dev zatkins-dev

Labels
CI style
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zatkins-dev @jeremylt