Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ground truth comparison feature to Python (resolves #410) #581

Closed
wants to merge 1 commit into from

Conversation

miguelcsx
Copy link
Contributor

Description

This PR addresses issue #410 by adding a ground truth comparison feature to the Python implementation. This feature was initially introduced in PR #396 for the MATLAB algorithms but was not implemented for Python due to time constraints.

Key Changes

  • Fixed a typo in the documentation related to the comparison feature.

Related Issue

Motivation

This feature is crucial for ensuring that the outputs of the Python algorithms can be compared to known ground truth data, providing better validation and accuracy checks similar to the MATLAB functionality.

Notes

This PR builds on the foundation laid by PR #396 but specifically focuses on the Python side of the implementation. Further improvements could include extending this feature to other algorithms as needed.

@miguelcsx miguelcsx marked this pull request as draft September 14, 2024 02:12
@miguelcsx miguelcsx marked this pull request as ready for review September 14, 2024 04:33
- added support for `groundtruth` image comparison in
  `iterative_recon_alg`.

- implemented `groundtruth` handling in error measurement and
  initialization.

- updated documentation to reflect new parameter and its usage.
@miguelcsx miguelcsx closed this by deleting the head repository Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ground truth comparison flag to python
1 participant