Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added DGA detector #57

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

jirkaseta
Copy link

Modul implements detector of DGA domains. Work is the result of the bachelor thesis.

@jirkaseta
Copy link
Author

Can someone tell me the reason of the error during the Travis build? I have no clue where is the problem. Thanks.

@cejkato2
Copy link
Contributor

We migrated to github actions. Please, update this branch with the latest version from master to solve the issue with failed travis build.

@krkos
Copy link
Contributor

krkos commented Feb 7, 2022

@jirkaseta
The pull request is unreviewable in its current form. Instead of one commit, several megabytes in size, could you split it into several? At least the data files could be split out. Also the infrastructure changes could be probably committed separately from actual logic. Please, start a new branch from current master.
As for estimator.c, it seems auto-generated from some previous model (sorry, I have not read your thesis yet) - could the source data be used instead and the estimator generated during build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants