Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for CI (black) #78

Merged
merged 2 commits into from
Apr 21, 2024
Merged

fix for CI (black) #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d34848a
fix ci
tomsail Apr 5, 2024
5a4e023
ci: removed formatting.yml
tomsail Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions .github/workflows/formatting.yml
View file
Open in desktop

This file was deleted.

5 changes: 4 additions & 1 deletion .github/workflows/testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
steps:
- uses: actions/setup-python@v2
with:
python-version: "3.x"
python-version: "3.7"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the 3.x imply that many versions of Python would be tested? Is it possible to test the last three trailing versions minus the current (which is typically always problematic)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a sort of "wildcard" that matches the latest minor python3 version in github CI.
Since @pmav99 suggested to use the lowest available, I changed it to 3.7

- uses: actions/checkout@v2
- name: Lint with flake8
run: |
Expand All @@ -34,6 +34,9 @@ jobs:
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
- name: Update
run: |
sudo apt update
- name: Install CGAL 5
run: |
sudo apt install -y libcgal-dev
Expand Down
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
[build-system]
requires = ["setuptools>=42", "wheel", "pybind11>=2.6.0", "versioneer-518"]
build-backend = "setuptools.build_meta"

[tool.black]
target-version = ['py37']
Loading