Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting posix platform and adding integration tests for Linux #9

Merged
merged 5 commits into from
Feb 22, 2023
Merged

Porting posix platform and adding integration tests for Linux #9

merged 5 commits into from
Feb 22, 2023

Conversation

RLeclair
Copy link
Collaborator

@RLeclair RLeclair commented Feb 7, 2023

  • Ported posix implementation for platform (only compiles for Linux)
  • Added integration tests for Linux

ewertons
ewertons approved these changes Feb 7, 2023
View reviewed changes
sdk/src/azure/platform/az_win32.c
(void)timer;
(void)milliseconds;

return AZ_ERROR_DEPENDENCY_NOT_PROVIDED;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking if it's intentional to not have these implemented at this time.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, we are currently focusing on the Linux posix scenario, but will get back to win32 later.

CIPop
CIPop approved these changes Feb 9, 2023
View reviewed changes
Copy link
Owner

@CIPop CIPop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RLeclair !

sdk/src/azure/platform/az_posix.c Show resolved Hide resolved
sdk/src/azure/platform/az_posix.c Outdated Show resolved Hide resolved
sdk/src/azure/platform/az_posix.c Outdated Show resolved Hide resolved
sdk/src/azure/platform/az_posix.c Show resolved Hide resolved
sdk/src/azure/platform/az_posix.c Outdated Show resolved Hide resolved
sdk/tests/platform/test_az_platform.c Show resolved Hide resolved
sdk/tests/platform/test_az_platform.c Outdated Show resolved Hide resolved
sdk/tests/platform/test_az_platform.c Outdated Show resolved Hide resolved
sdk/tests/platform/test_az_platform.c Show resolved Hide resolved
@RLeclair RLeclair merged commit 02fa4be into CIPop:v2 Feb 22, 2023
@RLeclair RLeclair deleted the raulleclair/posix_port branch February 22, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericwolz ericwolz ericwolz approved these changes

@ewertons ewertons ewertons approved these changes

@CIPop CIPop CIPop approved these changes

@danewalton danewalton Awaiting requested review from danewalton

@vaavva vaavva Awaiting requested review from vaavva

@JoseSanchez7 JoseSanchez7 Awaiting requested review from JoseSanchez7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RLeclair @CIPop @ewertons @ericwolz