Allow static libs #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hefroy
force-pushed
the
allow-static-libs
branch
3 times, most recently
from
46b983a
to
7429731
Compare
hefroy
changed the title
hefroy
force-pushed
the
allow-static-libs
branch
from
7429731
to
0184434
Compare
hefroy
changed the title
- Remove SHARED option from add_library to allow static libs, CMake then respects the standard BUILD_SHARED_LIBS option.
hefroy
force-pushed
the
allow-static-libs
branch
from
0184434
to
b0194fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use singleton LoggerImpl to avoid problems with static lib startup order.Fix uninitialized member variable (found using valgrind).These two issues were resolved by commit e3818cb