Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including missing <string> include #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kheaactua
Copy link

This appears to be required with g++14.

Without it I get:

[ 72%] Building CXX object CMakeFiles/CommonAPI.dir/src/CommonAPI/ProxyManager.cpp.o                                                                                                                                                                                                                                          
In file included from /home/matt/workspace/capicxx-import-tools/conan/capicxx-core-runtime/src/include/CommonAPI/Config.hpp:13,                                                                                                                                                                                               
                 from /home/matt/workspace/capicxx-import-tools/conan/capicxx-core-runtime/src/include/CommonAPI/CallInfo.hpp:13,                                                                                                                                                                                             
                 from /home/matt/workspace/capicxx-import-tools/conan/capicxx-core-runtime/src/src/CommonAPI/CallInfo.cpp:6:                                                                                                                                                                                                  
/home/matt/workspace/capicxx-import-tools/conan/capicxx-core-runtime/src/include/CommonAPI/Types.hpp:113:40: error: return type ‘std::string’ {aka ‘class std::__cxx11::basic_string<char>’} is incomplete                                                                                                                    
  113 |     virtual std::string getEnv() const {                                                                                                                                                                                                                                                                              
      |                                        ^                                                                                                                                                                                                                                                                              
/home/matt/workspace/capicxx-import-tools/conan/capicxx-core-runtime/src/include/CommonAPI/Types.hpp:116:48: error: return type ‘std::string’ {aka ‘class std::__cxx11::basic_string<char>’} is incomplete                                                                                                                    
  116 |     virtual std::string getHostAddress() const {

This is with:

-- The C compiler identification is GNU 14.1.1                                                                                                                                                                                                                                                                              
-- The CXX compiler identification is GNU 14.1.1

This appears to be required with g++14
@kheaactua
Copy link
Author

This seems identical to #49 .. I should have checked before posting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant