Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor InputStream-class fixes #48

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Minor InputStream-class fixes #48

wants to merge 3 commits into from

Commits on Aug 12, 2024

  1. Fix -Wduplicated-branches compiler warning 

    When InputStream::_readBitValue template is instantiated
with sizeof(Type_)==1 an if-statement had two identical brances.
    @vifactor
    vifactor committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    bab5098 View commit details
    Browse the repository at this point in the history

  2. Make isLittleEndian flag a InputStream class member 

    hence remove TODO
    @vifactor
    vifactor committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    2d6a57e View commit details
    Browse the repository at this point in the history

  3. Fix uninitialized variable in InputStream::readValue 

    itsSize variable at certain execution paths could remain
uninitializedi (i.e. contain garbage) before assignment to maxSize

additionally, this change decreases the scope of maxSize

Signed-off-by: Viktor Kopp <[email protected]>
    @vifactor
    vifactor committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    16df239 View commit details
    Browse the repository at this point in the history