Testable search #505
Merged
Testable search #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vifactor
force-pushed
the
testable-search
branch
3 times, most recently
from
2a8b0a6
to
7e85ee4
Compare
If timestamp range search is selected the loop will only continue if range is valid. It does not make sense to check in functions below if range is valid since otherwise that code cannot be even reached
vifactor
force-pushed
the
testable-search
branch
from
7e85ee4
to
806feb9
Compare
vifactor
force-pushed
the
testable-search
branch
from
806feb9
to
a3de08f
Compare
move matcher to qdlt lib enable c++17 in qmake config The new code uses variant and optional added in c++17 standard while qmake config was setup restricted to c++11 enable tests only if gtest package found Set c++17 standard in cmake export class for windows linker Signed-off-by: Viktor Kopp <[email protected]>
vifactor
force-pushed
the
testable-search
branch
from
a3de08f
to
bae0a27
Compare
|
@alexmucde any thoughts on this? in principle the PR is ready. |
|
Is c++1z the name for C++17? |
yes, this is the only way I was able to enforce it for "Build macOS (macos-13, Xcode_15.2)"-job. AFAIR, Win, Lin and Mac-14 were green if I use If we the project maintained only cmake build system, things would be simpler and cleaner. But I guess there is a reason you have to maintain both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search dialog core functionality is moved into a separate class.
Added unit tests for the class. Without this change I do not believe it is possible to make any "reliable" improvements for the search.
The unit tests are so far run only locally. CI adjustments can be done later if this PR is merged
The "payload range" functionality is not implemented: it does not work in the
master-branch and requirements are unclear.Since in this PR I use
optionalandvariantI also switch on c++17 standard where these utils were introduced. If not acceptable, in principle code can be rewritten without them. See #501I tested the refactored search functionality on several dlt file manually, so far I did not see issues.