install qoffscreen plugin on windows #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do not have windows at the moment so cannot check the change for real. The built package now contains it |
|
@vifactor It is then also missing in build_sdk_windows_qt5_MSVC.bat, please fix also there |
|
Sure, I'll have a look. It will take some time, though, I am away from my laptop for ~10 days. |
COVESA#508 Signed-off-by: Viktor Kopp <[email protected]>
vifactor
force-pushed
the
install-offscreeen-plugin
branch
from
c0120e6
to
ef133b3
Compare
|
@alexmucde since I do not know what exactly that .bat-file does, please have a look, I made the requested change |
|
@vifactor The script is used to build DLT Viewer for Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#508
offscreen plugin is required since this change: 990abad
Probably using
windeployqt-tool for packaging could have avoid this bug