change parent of actions in config context menu #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MainWindow was set as a parent of the context menu actions as a result all actions ever created (upon each ctx menu open) in one program session remained on heap until program is closed. Assigning local menu variable as a parent deallocates actions when menu is closed Signed-off-by: Viktor Kopp <[email protected]>
vifactor
force-pushed
the
optimize-memory-usage-of-ctx-menu
branch
from
15f6aee
to
a596554
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MainWindow was set as a parent of the context menu actions as a result all actions ever created (upon each ctx menu open) in one program session remained on the heap until program is closed (it is basically some kind of resources leak). Assigning local menu variable as a parent deallocates actions when menu is closed