Make code backward compatible with Qt 5.12 #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Names of the signals changed between Qt 5.12 and 5.15, while we still need to maintain compatibility with 5.12 Signed-off-by: Viktor Kopp <[email protected]>
|
@alexmucde this should address #519 (comment) I cannot check this against Qt 5.12, cause it would require to setup the environment, but change is rather trivial. |
|
you could test it in the pipeline by switching global to 5.12.... |
|
Builds in Ubunut 20.04, will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Names of the signals changed between Qt 5.12 and 5.15, while we still need to maintain compatibility with 5.12