Use QCommandLineParser for command line args parsing #543
Conversation
- avoid code duplication by reusing help text in main window - add tests Add QDltOptManager::reset method to have possibility to test the singleton Signed-off-by: Viktor Kopp <[email protected]>
vifactor
force-pushed
the
qcommandlineparser
branch
from
71d6e78
to
6217068
Compare
|
@alexmucde you asked to add "ready"-label when PR is ready, since I do not have rights to add labels, I notify you with the message, that this PR is ready for review |
…)" This reverts commit 5bab5b5.
|
@vifactor I had to reverse this change, as it caused several issues on my side and other users. E.g. the order of the parameters are now important. On my side export to CSV was not working anymore, perhaps also an issue of the order. Please provide a new PR when things are fixed. |
|
@vifactor Please provide the change also for the tool dlt-commander, if possible. |
|
@vifactor The export works, but the order was important for the -t option; |
|
@alexmucde first of all sorry for the troubles. Thanks for providing the exact failing command, I was about to ask what exactly fails. I'll try to investigate, should not be hard with the unit tests. |
|
@vifactor I gave you also the "Write" role in the project. Please try if you can now set labels in the PRs and perhaps you can also push branches directly to the project. |
|
I tried: I can now assign labels. Thank you, I appreciate the trust! |
|
@alexmucde I can't reproduce the issue you mentioned. The commands Could you please specify your OS, Qt version and how exactly the command misbehaves for you? If possible, also provide several exact commands that failed (for example I successfully converted a dlt to csv from command line using |
)" This reverts commit 3e370ec. Signed-off-by: Viktor Kopp <[email protected]>
)" (#566) This reverts commit 3e370ec. Signed-off-by: Viktor Kopp <[email protected]>
As a side effect this PR removes some code duplication which had to be kept in sync + cmd parsing functionality is now handled by the Qt and the logic for combining those args is tested (at least those combinations that are given in examples)