Minor tablemodel cleanup #551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktor Kopp <[email protected]>
… table model Signed-off-by: Viktor Kopp <[email protected]>
Signed-off-by: Viktor Kopp <[email protected]>
Rename getmessage -> getMessage Signed-off-by: Viktor Kopp <[email protected]>
Signed-off-by: Viktor Kopp <[email protected]>
Signed-off-by: Viktor Kopp <[email protected]>
vifactor
commented
Sep 29, 2024
| if ( decodeflag == 1 ) | ||
| { | ||
| decodeflag = 0; | ||
| pluginManager->decodeMsg(msg, !QDltOptManager::getInstance()->issilentMode()); |
There was a problem hiding this comment.
@alexmucde initially I had a look to this file to understand if I can remove usage of QDltOptManager singleton in here. this is the only place it is used. Do you know how issilentmode command option relates to triggeredByUser argument of the decodeMsg? Can I simply pass false here? I know it is not used in the existing plugins, however I am not sure about third-party ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainly code duplication removal. Much easier to review commit-by-commit.
This activty revealed two directions for further improvements: