Remove byteBuffer type (use array of bytes) #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't really implemented in several places anyway, but this removes some remaining references to this type. The byteBuffer type is superfluous since it can be represented by an array of uint8. It was at an earlier time also removed from the VSS project. Another alternative is the IFEX 'opaque' type. It was conceived to indicate that something in reality has structure but that it cannot (or is chosen not to) have a detailed represented in the IFEX description. An Opaque type is presumably also transferred as "just a bunch of bytes" in a computing system - only the name infers there is some additional meaning. Signed-off-by: Gunnar Andersson <gunnar_dev@[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't really implemented in several places anyway, but this removes some remaining references to this type.
The byteBuffer type is superfluous since it can be represented by an array of uint8. It was at an earlier time also removed from the VSS project. Another alternative is the IFEX 'opaque' type. It was conceived to indicate that something in reality has structure but that it cannot (or is chosen not to) have a detailed represented in the IFEX description. An Opaque type is presumably also transferred as "just a bunch of bytes" in a computing system - only the name infers there is some additional meaning.
Note: These are older commits that were not written during MBition employment.