D-Bus / sdbus-c++: cmake flag was changed #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helper build script that compiles the sdbus-c++-xml2cpp compiler is based on git-cloning the latest master branch, instead of locking it into a specific version. An incompatible change was introduced there, for the name of the CMAKE flag that is used to cause the code-generator binary to be built. Renaming the flag in our script makes the build work again. (It was, and still is, *NOT* caught by regression testing, since this is a small and complementary helper, and not really part of the core delivered tools, so not a big issue.) Signed-off-by: Gunnar Andersson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author: Gunnar Andersson <[email protected]>, MBition GmbH.
D-Bus / sdbus-c++: cmake flag was changed
The helper build script that compiles the sdbus-c++-xml2cpp compiler is based on git-cloning the latest master branch, instead of locking it into a specific version. An incompatible change was introduced there, for the name of the CMAKE flag that is used to cause the code-generator binary to be built. Renaming the flag in our script makes the build work again.
The program was tested solely for our own use cases, which might differ from yours.
The submission is provided under the main project license (LICENSE file in root of project).
Provider Information