Update on Mirror & Coding Guidelines #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cabin_Climate_topics proto. Same will applied to rest of the project. once its accepted.
mirrors at the same time. This will reduce the number of rps calls to react on both mirriors.
ravurinaresh
changed the title
|
Updated Climate for coding guidelines |
|
@ravurinaresh why (hex in lieu of decimal)? |
|
I had similar question. |
|
Hello,I couldn’t find coding guidelines for COVESA. Can you please point to me? If doesn’t exist. May be better develop coding guidelines by adopting from AUTOSAR?Usage of HEX avoid confusion and make it clear while debugging and also avoid mistakes while coding like usage of 08 considers as Octal number rather than decimal number in some occasions.How to stop a compiler from assuming octal?stackoverflow.comRegards,Naresh RavuriSent from my iPhoneOn Mar 25, 2024, at 9:30 AM, halimragab ***@***.***> wrote:
I had similar question.
Also which coding guideline being updated ?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Hi @ravurinaresh let us discuss in a call when we can and we can decide what to do with this PR |
|
Sure. Are there any weekly calls Scheduled?
Regards,
Naresh Ravuri
…On Tue, Apr 9, 2024 at 1:03 PM halimragab ***@***.***> wrote:
Hi @ravurinaresh <https://github.com/ravurinaresh> let us discuss in a
call when we can and we can decide what to do with this PR
—
Reply to this email directly, view it on GitHub
<#7 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT4BLOSDT3MDHN3K2XH5ESLY4QNPRAVCNFSM6AAAAABFF54D22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBVGY4DQNBRGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
--
Naresh Ravuri.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decimal values are replaced with Hex values in Cabin_Climate_topics proto.
Same will applied to rest of the project. once its accepted.