Implement slog2 logging capability #713
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kheaactua
commented
May 28, 2024
kheaactua
force-pushed
the
logging_updates
branch
7 times, most recently
from
9f2b8c5
to
944902b
Compare
slog2 is enabled by default, but guarded with #ifdef __QNX__. It can be
controlled with /etc/vsomeip/logging.json, i.e.:
```json
"logging": {
"slog2": true
}
```
This code allocates 4 pages (16kB) by default, but the caller can provide
an environment variable VSOMEIP_SLOG2_NUM_PAGES to control the allocation
Minimal CMake changes were made to link against the slog2 library on QNX
This commit also modifies the routingmanager example to set the
LogApplication property which is used as the log tag for AOSP logcat
logging.
kheaactua
force-pushed
the
logging_updates
branch
from
058f6af
to
eabbfee
Compare
kheaactua
commented
Sep 16, 2024
| @@ -14,9 +14,6 @@ find_package(benchmark) | |||
| ############################################################################## | |||
| # google test | |||
|
|
|||
| # remove export symbols from the cxx flags | |||
| string(REPLACE "${EXPORTSYMBOLS}" "" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}") | |||
|
|
|||
| # check for set environment variable | |||
There was a problem hiding this comment.
I think I found a problem with this in another PR, I also have a solution there though.
There was a problem hiding this comment.
rebased this to 3.5.1 locally, will push it soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implement logging to slog2 when run on QNX.
Description
Implemented an slog2 logging capability into the logger which is enabled by default on QNX systems. The implementation in general is guarded with build defines, i.e.
#ifdef __QNX__.The configuration object was modified such that the slog2 logging can be controlled with
/etc/vsomeip/logging.json, i.e.:This code allocates 4 pages (16kB) by default, but the caller can provide an environment variable
VSOMEIP_SLOG2_NUM_PAGESto control the allocationThe logger must be initialized prior to calling config through the implementation. Because non-CommonAPI apps (e.g.
routingmanagerd) can use the VSOMEIP logging macros which would trigger a logging seg fault, the message object will now output the message in the erroneous case rather than raising a seg fault.Other changes
version-scriptis applied as a private linker option tolibvsomeip, this removes the need to remove it from theCXX_FLAGSin the test's CMake setup.runtime->setProperty("LogApplication");in theroutingmanagerdexample such that it had a log tag to filter on in logcat (Android only)Testing